From: Bob Peterson <rpeterso@redhat.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
cluster-devel@redhat.com, Hannes Reinecke <hare@suse.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH 0/6] gfs2/buffer folio changes
Date: Fri, 2 Jun 2023 08:25:39 -0500 [thread overview]
Message-ID: <16d964a4-755f-53c8-b7bf-43584acdd380@redhat.com> (raw)
In-Reply-To: <4530554c-c2b3-f93b-6c2c-c411e62d1e45@redhat.com>
On 6/2/23 7:30 AM, Bob Peterson wrote:
> On 5/16/23 10:24 PM, Matthew Wilcox (Oracle) wrote:
>> This kind of started off as a gfs2 patch series, then became entwined
>> with buffer heads once I realised that gfs2 was the only remaining
>> caller of __block_write_full_page(). For those not in the gfs2 world,
>> the big point of this series is that block_write_full_page() should now
>> handle large folios correctly.
>>
>> It probably makes most sense to take this through Andrew's tree, once
>> enough people have signed off on it?
> Hi Willy,
>
> I did some fundamental testing with this patch set in a five-node
> cluster, as well as xfstests, and it seemed to work properly. The
> testing was somewhat limited, but it passed basic cluster coherency
> testing. Sorry it took so long.
>
> If you want you can add:
> Tested-by: Bob Peterson <rpeterso@redhat.com>
> Reviewed-by: Bob Peterson <rpeterso@redhat.com>
>
> Regards,
>
> Bob Peterson
I was talking with Andreas G and he still has some concerns, so don't
push this to a repo quite yet.
Regards,
Bob Peterson
prev parent reply other threads:[~2023-06-02 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 3:24 [PATCH 0/6] gfs2/buffer folio changes Matthew Wilcox (Oracle)
2023-05-17 3:24 ` [PATCH 1/6] gfs2: Use a folio inside gfs2_jdata_writepage() Matthew Wilcox (Oracle)
2023-05-17 3:24 ` [PATCH 2/6] gfs2: Pass a folio to __gfs2_jdata_write_folio() Matthew Wilcox (Oracle)
2023-05-17 3:24 ` [PATCH 3/6] gfs2: Convert gfs2_write_jdata_page() to gfs2_write_jdata_folio() Matthew Wilcox (Oracle)
2023-06-03 9:34 ` Andreas Gruenbacher
2023-06-04 3:35 ` Matthew Wilcox
2023-06-04 7:27 ` Andreas Gruenbacher
2023-05-17 3:24 ` [PATCH 4/6] buffer: Convert __block_write_full_page() to __block_write_full_folio() Matthew Wilcox (Oracle)
[not found] ` <CGME20230517144703eucas1p1550db888e29fc5b182c202f24adddb87@eucas1p1.samsung.com>
2023-05-17 14:47 ` Pankaj Raghav
2023-05-17 15:43 ` Matthew Wilcox
2023-05-17 3:24 ` [PATCH 5/6] gfs2: Support ludicrously large folios in gfs2_trans_add_databufs() Matthew Wilcox (Oracle)
2023-05-23 12:46 ` Andreas Gruenbacher
2023-05-23 13:37 ` Matthew Wilcox
2023-06-03 9:46 ` Andreas Gruenbacher
2023-05-17 3:24 ` [PATCH 6/6] buffer: Make block_write_full_page() handle large folios correctly Matthew Wilcox (Oracle)
2023-05-17 18:06 ` [PATCH 0/6] gfs2/buffer folio changes Bob Peterson
2023-06-02 12:30 ` Bob Peterson
2023-06-02 13:25 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d964a4-755f-53c8-b7bf-43584acdd380@redhat.com \
--to=rpeterso@redhat.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=hare@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).