From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAC4C46467 for ; Tue, 10 Jan 2023 16:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234235AbjAJQUn (ORCPT ); Tue, 10 Jan 2023 11:20:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233763AbjAJQUk (ORCPT ); Tue, 10 Jan 2023 11:20:40 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E291A755D6 for ; Tue, 10 Jan 2023 08:19:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673367588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vo+r1QQ4ck/ppanavjFv3Ae00jvXHJ/nRrcL6yv9HGA=; b=IEGGlGlf9dTSxDPxEltmSg1rGKIkzwL0P7b1z9Q/7P537nI0FqmD7bRwWqfqsge2d75x0k AarQi0abv3MUYLzMs6F8S+R80RJRh8lOGeU0ySTNMMP27KE0gsl5AWFlOh2rgAkV41WQd3 FlHnn2MZqg8QpUSvjWxVyFX1qu6qz2k= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-363-Ld0tYrBgOBSETM4N_OWyvg-1; Tue, 10 Jan 2023 11:19:34 -0500 X-MC-Unique: Ld0tYrBgOBSETM4N_OWyvg-1 Received: by mail-lj1-f198.google.com with SMTP id w9-20020a2e9989000000b002831e1aaac6so2125297lji.14 for ; Tue, 10 Jan 2023 08:19:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Vo+r1QQ4ck/ppanavjFv3Ae00jvXHJ/nRrcL6yv9HGA=; b=IKk3gHnGtTCx/db4fGjvblLFaoujM5W0Gx4ItwSu716f5WL3fBvRJHV71vRiCAud+x Cc0VfEp5G9k5rPztAj2oD0Boof0V29TkbV0VSvvimP5rgOa0GlZR95j06K1YQw+mlRML LzhXVuUDGFLmbUAhuKdrMkJlHhH94rp4REBMpfvGig2EsPmx4ppYloTXnMF4FURMIit0 q7RB2PjgRnVgt9CiBnQVwH2Uby2lRNTlEkgEVVNHFX8UskQ6W2H6+huSyyexo6whsQJU m5WyUiGeu+h3dqJxSKVOPs9EMJOVedr+IC+2tFLGs8w8/9gPfJukQtiakZc8d85Dzlzk IVfA== X-Gm-Message-State: AFqh2krW+5GRxo9KBNd1Xx3eL7YXxkr8QaXBVfBHnne7vwnqnErrBLQL 1mJ9niwd8kehLghUYk9r0CXmtAs5CmC/c383SBbO99GSO7vI5jq16b+UM51rVSjTprcPkrg3Tzi hQIpXaK2jPUyHnWWVPQ8U/An09g== X-Received: by 2002:a05:6512:1688:b0:4ca:fa75:a64a with SMTP id bu8-20020a056512168800b004cafa75a64amr19815672lfb.0.1673367566843; Tue, 10 Jan 2023 08:19:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXs9mNJdkoKcb9Bdob/hPwc/Y8uVxKrapTtbGK5haICO4IputBLiq8G82i1OgWpJOQdtSnW/HA== X-Received: by 2002:a05:6512:1688:b0:4ca:fa75:a64a with SMTP id bu8-20020a056512168800b004cafa75a64amr19815666lfb.0.1673367566672; Tue, 10 Jan 2023 08:19:26 -0800 (PST) Received: from greebo.mooo.com (c-e6a5e255.022-110-73746f36.bbcust.telenor.se. [85.226.165.230]) by smtp.gmail.com with ESMTPSA id y19-20020ac24473000000b004946b549a19sm2256542lfl.45.2023.01.10.08.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 08:19:26 -0800 (PST) Message-ID: <16f071eb34083b6248dd50b204e8f9979b091647.camel@redhat.com> Subject: Re: [PATCH 2/6] composefs: Add on-disk layout From: Alexander Larsson To: Brian Masney Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, gscrivan@redhat.com Date: Tue, 10 Jan 2023 17:19:25 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 2023-01-05 at 10:55 -0500, Brian Masney wrote: > On Mon, Nov 28, 2022 at 12:16:23PM +0100, Alexander Larsson wrote: > > This commit adds the on-disk layout header file of composefs. > >=20 > > Signed-off-by: Alexander Larsson > > Signed-off-by: Giuseppe Scrivano >=20 > Add Co-Developed-By: Giuseppe ... ? >=20 > Full disclosure: I'm not a file system developer but I'll attempt to > help with the review of this series. >=20 Thanks. I did various changes to the github repo based on your review, here are the outstanding comments: >=20 > > +struct cfs_header_s { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 version; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u8 unused1; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u16 unused2; > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u32 magic; >=20 > Should the magic number appear first? I don't think so, the version number is essentially part of the full magic string. >=20 >=20 --=20 =3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D= -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- =3D-=3D-=3D Alexander Larsson Red Hat, Inc=20 alexl@redhat.com alexander.larsson@gmail.com=20 He's a notorious vegetarian filmmaker who knows the secret of the alien invasion. She's an artistic tomboy nun married to the Mob. They fight=20 crime!=20