From: "Mike Snitzer" <snitzer@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Nick Piggin" <npiggin@suse.de>, "Kirill Korotaev" <dev@openvz.org>
Subject: potential regression in ext[34] call to __page_symlink()?
Date: Tue, 28 Oct 2008 20:11:48 -0400 [thread overview]
Message-ID: <170fa0d20810281711s2a508ed2o1af0db30733e8d2d@mail.gmail.com> (raw)
The gfp_mask that is passed to __page_symlink() is being completely
dropped on the floor. Historically this mask was at least used by
ext3 and ext4 to avoid recursing back into the FS from within a
journal transaction; Kirill fixed that issue with this commit:
0adb25d2e71ab047423d6fc63d5d184590d0a66f
I'm quite naive when it comes to Nick's relatively new (>= 2.6.24) AOP
pagecache_write_{begin,end} code that motivated __page_symlink to
change with this commit:
afddba49d18f346e5cc2938b6ed7c512db18ca68
Nick's change clearly did away with using the explicitly passed
gfp_mask in __page_symlink().
So at a minimum it would seem __page_symlink() now has an unused
parameter that should be removed.
But a more serious concern would be: have ext[34]_symlink() regressed
to being susceptible to the bug that Kirill fixed some time ago?
Please advise, thanks.
Mike
next reply other threads:[~2008-10-29 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 0:11 Mike Snitzer [this message]
2008-10-29 2:40 ` potential regression in ext[34] call to __page_symlink()? Theodore Tso
2008-10-29 3:25 ` Nick Piggin
2008-10-29 15:40 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170fa0d20810281711s2a508ed2o1af0db30733e8d2d@mail.gmail.com \
--to=snitzer@gmail.com \
--cc=dev@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).