From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Danilov <nikita@clusterfs.com>
Subject: Re: [PATCH, RFC] map multiple blocks at a time in mpage_readpage(s)
Date: Wed, 5 Oct 2005 10:04:48 +0400
Message-ID: <17219.27904.659471.559297@gargle.gargle.HOWL>
References: <20051004194246.GA18432@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from moraine.clusterfs.com ([66.96.26.190]:26071 "EHLO
	moraine.clusterfs.com") by vger.kernel.org with ESMTP
	id S932553AbVJEHEP (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 5 Oct 2005 03:04:15 -0400
To: Christoph Hellwig <hch@lst.de>
In-Reply-To: <20051004194246.GA18432@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Christoph Hellwig writes:

[...]

 >  					page->index, GFP_KERNEL)) {
 >  			bio = do_mpage_readpage(bio, page,
 >  					nr_pages - page_idx,
 > -					&last_block_in_bio, get_block);
 > +					&last_block_in_bio, &map_bh,
 > +					&first_logical_block, &map_valid,
 > +					get_blocks, get_block);

Oh, function taking 9 arguments, please... this is not windows.

By the way, I cannot see where get_block callback is used by mpage.c
code, why is it needed?

Nikita.