From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2
Date: Wed, 16 May 2007 14:25:04 +0100
Message-ID: <17317.1179321904@redhat.com>
References: <1179317360.2859.225.camel@shinybook.infradead.org> <20070318233008.GA32597093@melbourne.sgi.com> <18993.1179310769@redhat.com>
Cc: David Chinner <dgc@sgi.com>, lkml <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: David Woodhouse <dwmw2@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:58630 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757948AbXEPNZM (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 16 May 2007 09:25:12 -0400
In-Reply-To: <1179317360.2859.225.camel@shinybook.infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

David Woodhouse <dwmw2@infradead.org> wrote:

> Really? Is it _really_ going to be modified?

Well, generic_file_buffered_write() doesn't check the success of the copy
before calling commit_write(), presumably because it uses
fault_in_pages_readable() first.

David