From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DA2C05052 for ; Fri, 18 Aug 2023 11:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376560AbjHRLnj (ORCPT ); Fri, 18 Aug 2023 07:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376533AbjHRLn1 (ORCPT ); Fri, 18 Aug 2023 07:43:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B7B130E6 for ; Fri, 18 Aug 2023 04:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692358961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nIJDtceJEvPvpHYLAnup+4KqtuQicSCLwPh42Fs8LnI=; b=Y5MnWl41zAuMQGUZ0CjhuOqJq2+YtqeZI/GR+iYMSi24FCziANvOsD8H9IUnLSQgiKNVxR UyEQ39uuj5BKIlYqfO3K3+wzIg3FCowRq/UcVkrxHKpNNdmAsCOFUCravB47bm6DAldVwE bjNazRLIXB3ot2LG+9Lhtb3CQgyzBns= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-Js43KPOeMVmCnPjUHe8Lfw-1; Fri, 18 Aug 2023 07:42:36 -0400 X-MC-Unique: Js43KPOeMVmCnPjUHe8Lfw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 691DE1C0755C; Fri, 18 Aug 2023 11:42:34 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA67C1121314; Fri, 18 Aug 2023 11:42:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <03730b50cebb4a349ad8667373bb8127@AcuMS.aculab.com> <20230816120741.534415-1-dhowells@redhat.com> <20230816120741.534415-3-dhowells@redhat.com> <608853.1692190847@warthog.procyon.org.uk> <3dabec5643b24534a1c1c51894798047@AcuMS.aculab.com> <665724.1692218114@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, David Laight , Al Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Matthew Wilcox , Jeff Layton , "linux-fsdevel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/2] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1748359.1692358952.1@warthog.procyon.org.uk> Date: Fri, 18 Aug 2023 12:42:32 +0100 Message-ID: <1748360.1692358952@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Linus Torvalds wrote: > Well, that part is trivially fixable, and we should do that anyway for > other reasons. > .. > enum iter_type { > /* iter types */ > - ITER_IOVEC, > - ITER_KVEC, > - ITER_BVEC, > - ITER_XARRAY, > - ITER_DISCARD, > - ITER_UBUF, > + ITER_IOVEC = 1, > + ITER_UBUF = 2, > + ITER_KVEC = 4, > + ITER_BVEC = 8, > + ITER_XARRAY = 16, > + ITER_DISCARD = 32, > }; It used to be this way, but Al switched it: 8cd54c1c848031a87820e58d772166ffdf8c08c0 iov_iter: separate direction from flavour David