From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Brown Subject: Re: [patch 16/44] rd convert to new aops Date: Tue, 24 Apr 2007 21:42:14 +1000 Message-ID: <17965.60694.712368.418752@notabene.brown> References: <20070424012346.696840000@suse.de> <20070424013434.737154000@suse.de> <20070424104647.GB13268@infradead.org> <20070424110549.GC32738@wotan.suse.de> <20070424111119.GA17085@infradead.org> <20070424111653.GB25413@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Andrew Morton , Linux Filesystems , Mark Fasheh To: Nick Piggin Return-path: Received: from mx2.suse.de ([195.135.220.15]:45976 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161712AbXDXLm0 (ORCPT ); Tue, 24 Apr 2007 07:42:26 -0400 In-Reply-To: message from Nick Piggin on Tuesday April 24 Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tuesday April 24, npiggin@suse.de wrote: > On Tue, Apr 24, 2007 at 12:11:19PM +0100, Christoph Hellwig wrote: > > On Tue, Apr 24, 2007 at 01:05:49PM +0200, Nick Piggin wrote: > > > On Tue, Apr 24, 2007 at 11:46:47AM +0100, Christoph Hellwig wrote: > > > > > + page = __grab_cache_page(mapping, index); > > > > > > > > btw, __grab_cache_page should probably get a more descriptive and > > > > non-__-prefixed name now that it's used all over the place. > > > > > > Agreed. Suggestions? ;) > > > > find_or_create_cache_page given that's it's like find_or_create_page + > > add_to_page_cache? > > find_or_create_page adds to page cache as well, though :P I would really like to see the word 'lock' in there, as it does return a locked page, and when I first saw __grab_cache_page recently there was an unlock_page afterwards and I couldn't see where the lock happened, and I was confused for a little while. NeilBrown