linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: "Jeff Zheng" <Jeff.Zheng@endace.com>
Cc: "Michal Piotrowski" <michal.k.k.piotrowski@gmail.com>,
	"Ingo Molnar" <mingo@elte.hu>, <linux-raid@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
Subject: RE: Software raid0 will crash the file-system, when each disk is 5TB
Date: Thu, 17 May 2007 10:48:02 +1000	[thread overview]
Message-ID: <17995.42562.870806.396617@notabene.brown> (raw)
In-Reply-To: message from Jeff Zheng on Wednesday May 16

On Wednesday May 16, Jeff.Zheng@endace.com wrote:
> Here is the information of the created raid0. Hope it is enough.

Thanks.
Everything looks fine here.

The only difference of any significance between the working and
non-working configurations is that in the non-working, the component
devices are larger than 2Gig, and hence have sector offsets greater
than 32 bits.

This does cause a slightly different code path in one place, but I
cannot see it making a difference.  But maybe it does.

What architecture is this running on?
What C compiler are you using?

Can you try with this patch?  It is the only thing that I can find
that could conceivably go wrong.

Thanks,
NeilBrown

Signed-off-by: Neil Brown <neilb@suse.de>

### Diffstat output
 ./drivers/md/raid0.c |    1 +
 1 file changed, 1 insertion(+)

diff .prev/drivers/md/raid0.c ./drivers/md/raid0.c
--- .prev/drivers/md/raid0.c	2007-05-17 10:33:30.000000000 +1000
+++ ./drivers/md/raid0.c	2007-05-17 10:34:02.000000000 +1000
@@ -461,6 +461,7 @@ static int raid0_make_request (request_q
  
 	while (block >= (zone->zone_offset + zone->size)) 
 		zone++;
+	BUG_ON(block < zone->zone_offset);
     
 	sect_in_chunk = bio->bi_sector & ((chunk_size<<1) -1);
 

  parent reply	other threads:[~2007-05-17  0:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15 23:09 Software raid0 will crash the file-system, when each disk is 5TB Jeff Zheng
2007-05-15 23:29 ` Michal Piotrowski
2007-05-16  0:03   ` Neil Brown
2007-05-16  1:56     ` Jeff Zheng
2007-05-16 17:28       ` Bill Davidsen
2007-05-16 17:58         ` david
2007-05-17  0:48       ` Neil Brown [this message]
2007-05-17  2:09         ` Jeff Zheng
2007-05-17  2:45           ` Neil Brown
2007-05-17  3:11             ` Jeff Zheng
2007-05-17  4:32               ` Neil Brown
2007-05-17  5:08                 ` Jeff Zheng
2007-05-17  4:45             ` david
2007-05-17  5:03               ` Neil Brown
2007-05-17  5:31                 ` Neil Brown
2007-05-17  5:38                   ` Jeff Zheng
2007-05-17 22:55                     ` Jeff Zheng
2007-05-18  0:21                       ` Neil Brown
2007-05-22 21:31                       ` Bill Davidsen
2007-05-16 14:04 ` Andreas Dilger
2007-05-16 18:04   ` david
2007-05-16 18:16     ` Jan Engelhardt
2007-05-16 21:42       ` Jeff Zheng
2007-05-17  7:21         ` Jan Engelhardt
2007-05-17 11:11           ` Neil Brown
2007-05-17 15:30             ` Jan Engelhardt
2007-05-16 21:44     ` Jeff Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17995.42562.870806.396617@notabene.brown \
    --to=neilb@suse.de \
    --cc=Jeff.Zheng@endace.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).