Re: [PATCH 1/8] filemap: Remove readahead_page()

[David Hildenbrand <david@redhat.com>]

On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote:
> All filesystems have now been converted to call readahead_folio()
> so we can delete this wrapper.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   include/linux/pagemap.h | 22 +++-------------------
>   1 file changed, 3 insertions(+), 19 deletions(-)
> 
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 26baa78f1ca7..cd4bd0f8e5f6 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -1308,9 +1308,9 @@ static inline bool filemap_range_needs_writeback(struct address_space *mapping,
>    * struct readahead_control - Describes a readahead request.
>    *
>    * A readahead request is for consecutive pages.  Filesystems which
> - * implement the ->readahead method should call readahead_page() or
> - * readahead_page_batch() in a loop and attempt to start I/O against
> - * each page in the request.
> + * implement the ->readahead method should call readahead_folio() or
> + * __readahead_batch() in a loop and attempt to start reads into each
> + * folio in the request.
>    *
>    * Most of the fields in this struct are private and should be accessed
>    * by the functions below.
> @@ -1415,22 +1415,6 @@ static inline struct folio *__readahead_folio(struct readahead_control *ractl)
>   	return folio;
>   }
>   
> -/**
> - * readahead_page - Get the next page to read.
> - * @ractl: The current readahead request.
> - *
> - * Context: The page is locked and has an elevated refcount.  The caller
> - * should decreases the refcount once the page has been submitted for I/O
> - * and unlock the page once all I/O to that page has completed.
> - * Return: A pointer to the next page, or %NULL if we are done.
> - */
> -static inline struct page *readahead_page(struct readahead_control *ractl)
> -{
> -	struct folio *folio = __readahead_folio(ractl);
> -
> -	return &folio->page;
> -}
> -
>   /**
>    * readahead_folio - Get the next folio to read.
>    * @ractl: The current readahead request.

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb