From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Brown Subject: Re: [patch 1/3] add the fsblock layer Date: Mon, 25 Jun 2007 09:01:32 +1000 Message-ID: <18046.63436.472085.535177@notabene.brown> References: <20070624014528.GA17609@wotan.suse.de> <20070624014613.GB17609@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Linux Kernel Mailing List , Linux Memory Management List , linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from ns.suse.de ([195.135.220.2]:53437 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbXFXXBm (ORCPT ); Sun, 24 Jun 2007 19:01:42 -0400 In-Reply-To: message from Nick Piggin on Sunday June 24 Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sunday June 24, npiggin@suse.de wrote: > > +#define PG_blocks 20 /* Page has block mappings */ > + I've only had a very quick look, but this line looks *very* wrong. You should be using PG_private. There should never be any confusion about whether ->private has buffers or blocks attached as the only routines that ever look in ->private are address_space operations (or should be. I think 'NULL' is sometimes special cased, as in try_to_release_page. It would be good to do some preliminary work and tidy all that up). Why do you think you need PG_blocks? NeilBrown