From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 455F8313552 for ; Fri, 24 Oct 2025 15:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761320568; cv=none; b=uykK4oBssFDmchPM4Dj1mOk3gEptUv19ArxbqXU8b1OUpv8qzbYihfpiOsEd/3tmxKmSqZs843UsiTEB0wYKrK3fgFb+altwLH/d1fQFLugn52ld1ewKt1KrxVUCJap8dod8uLgXs3s60KskFeXmKH+k2zChAX3iKxfHVnK07GY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761320568; c=relaxed/simple; bh=SDI94PUu79UY1fN/O11MyWzpILk0HRWd+qAdanW+Jgg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uwPoeuzvAnfjyMQZ1+1YTQoB7s7eiH8Jf9JeLM6MFFSZk8QcdowWkN4Ad94fDJNJEXlrsM9HSIrDpO2MOPZEHIYnOWjxtTzpi0SHPNfwf+9EF1/eHVJ/p7mXCZvFN/BENApiTCCjFz4jEhpbvEFuC2KTJLGlnCxp2llfYFVT9AQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F03O8p1d; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F03O8p1d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761320566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YCFQCFgPLJJHNF45uz8IXNSwQz2ZtuMOkcxhO1VgMIE=; b=F03O8p1dmSQhCfF/TGETGt9bCP1phpbyUaZTAWvXpZv3e7As2s+4AwZ57sctdxFq8RRD+f nRFEFSxkVYau58ElwtYKlVNySRKF49cBRxjYCE5InP4Chnn0toUWorqOr0Q4w3HezOs64G RY8b4f5oYbXY7cMEoMIHG1fYr7/sAKY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-TEfy-9taM5yJeeOj8rptQQ-1; Fri, 24 Oct 2025 11:42:43 -0400 X-MC-Unique: TEfy-9taM5yJeeOj8rptQQ-1 X-Mimecast-MFC-AGG-ID: TEfy-9taM5yJeeOj8rptQQ_1761320563 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42700160169so1463479f8f.1 for ; Fri, 24 Oct 2025 08:42:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761320562; x=1761925362; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YCFQCFgPLJJHNF45uz8IXNSwQz2ZtuMOkcxhO1VgMIE=; b=NoBQMlqe6tbNaaGEQuBOFL6SR/s/9z+7DyxvR1biY/nE/vLkZ9chnLQQncVBDh3/k8 Bo6+igujo+MJ0V9yxAX0Q9EDZs2F1o7L0pH9YNp9/qkZY4fmNG7pKrptqJiCcgXQ9Ve7 +oGrZtdr6255VgJNWSJB38M0xu0j8KEFMALNRPX/jUudxUvjVwA3qu2op1oHf/jfv60R XXSFowXSt4uu41MONrEWVNJLYAB3zV4R/bVUxfSyKjqpBAHzOrbFYhyUCjxeHNXdrwxB Rpcz4A3Yiu4c2gy68peR3GajUKv+ypj6nShxu38/KAEs5jGXD57pIkQeGA3Zhh/+DGbT ++EA== X-Forwarded-Encrypted: i=1; AJvYcCU/ozG6ntkJI6uDWaUdUvnynHvCmXFVceMPpvTPfminee7uZzMT06YceS2TG5plNw+7sM1IefuYfmltYgEH@vger.kernel.org X-Gm-Message-State: AOJu0YzDQvzNubAP0b8BVEopbaXdRq1vem64pt6sh0RC+5u0fLUr8ZUd rRj8pu7o2fYr/euHsKneSSztYyzhq/NDT9+4bQfn1Ea9aBTWAAJcUwZ4TEgpXFD/z+UOkpT6pYd MsLP+fTnM9X9U91wTbzkj0/3+1q3uO/cmRb0rEF1XVS7oW3MbFP0660O+nSj7bUVuh0Y= X-Gm-Gg: ASbGncs/ArIWTNrkSoNK80wfwVP5zaj2fTOOxxT1QR/+Hd+UBxbYTUNL1rRNZRloXKA 3h08RVkj9C9VyOQ2GZ6nvN+X8WUdoE4qVwHJGQjHioB3azbrs+bGlChIh3Gkm/ioC9g91uydxOL sm9tbXWWKhMo+z0BMa65go9boW5WvR02uXIEbtcSl0StmWXCxnyrntLP2VDaZJccmP5av2uWRIs PFt4ZpPbxBnlVhht/F6/lLyI2TFhOGBEBSddqOpHV3AxolPOOCaDlxwX89JNKufOYJwQt8E5CpV ziTs/BmvdmPDCabteEdG2TqJO/TRDL+x7H3R0R/I04AIFtttXD3tRamoA/JbU1QkwICofehe4Fx SSrq7yj9l9bgnOCerM6LbnSR3lnL2GcuCJ3lpjAExjgJJbqVxZxAjcU+q5Lq53n4IfewNBoJI/U 4ROf7koJIxpl2/3eORIFcC09hk61w= X-Received: by 2002:a05:6000:2689:b0:426:d820:a3f9 with SMTP id ffacd0b85a97d-42704c76535mr18604364f8f.0.1761320562522; Fri, 24 Oct 2025 08:42:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPnF0/ru3FWnNa1cDip4fvA/H/2f2hSvDV5kZEbyyXOBfqac/lKNoCd+rrZ3iEhhxjPCZDfA== X-Received: by 2002:a05:6000:2689:b0:426:d820:a3f9 with SMTP id ffacd0b85a97d-42704c76535mr18604343f8f.0.1761320562141; Fri, 24 Oct 2025 08:42:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3? (p200300d82f4e3200c99da38b3f3ad4b3.dip0.t-ipconnect.de. [2003:d8:2f4e:3200:c99d:a38b:3f3a:d4b3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429897f57b7sm9942229f8f.16.2025.10.24.08.42.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 08:42:40 -0700 (PDT) Message-ID: <18262e42-9686-43c1-8f5f-0595b5a00de1@redhat.com> Date: Fri, 24 Oct 2025 17:42:38 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 1/2] mm/memory: Do not populate page table entries beyond i_size To: Kiryl Shutsemau , Andrew Morton , Hugh Dickins , Matthew Wilcox , Alexander Viro , Christian Brauner Cc: Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Johannes Weiner , Shakeel Butt , Baolin Wang , "Darrick J. Wong" , Dave Chinner , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Kiryl Shutsemau References: <20251023093251.54146-1-kirill@shutemov.name> <20251023093251.54146-2-kirill@shutemov.name> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251023093251.54146-2-kirill@shutemov.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.10.25 11:32, Kiryl Shutsemau wrote: > From: Kiryl Shutsemau > > Accesses within VMA, but beyond i_size rounded up to PAGE_SIZE are > supposed to generate SIGBUS. > > Recent changes attempted to fault in full folio where possible. They did > not respect i_size, which led to populating PTEs beyond i_size and > breaking SIGBUS semantics. > > Darrick reported generic/749 breakage because of this. > > However, the problem existed before the recent changes. With huge=always > tmpfs, any write to a file leads to PMD-size allocation. Following the > fault-in of the folio will install PMD mapping regardless of i_size. > > Fix filemap_map_pages() and finish_fault() to not install: > - PTEs beyond i_size; > - PMD mappings across i_size; > > Signed-off-by: Kiryl Shutsemau > Fixes: 19773df031bc ("mm/fault: try to map the entire file folio in finish_fault()") > Fixes: 357b92761d94 ("mm/filemap: map entire large folio faultaround") > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Reported-by: "Darrick J. Wong" > --- Some of the code in here might deserve some cleanups IMHO :) [...] > addr0 = addr - start * PAGE_SIZE; > if (folio_within_vma(folio, vmf->vma) && > - (addr0 & PMD_MASK) == ((addr0 + folio_size(folio) - 1) & PMD_MASK)) { > + (addr0 & PMD_MASK) == ((addr0 + folio_size(folio) - 1) & PMD_MASK) && Isn't this just testing whether addr0 is aligned to folio_size(folio)? (given that we don't support folios > PMD_SIZE), like IS_ALIGNED(addr0, folio_size(folio)) Anyhow, unrelated to this patch ... Acked-by: David Hildenbrand -- Cheers David / dhildenb