From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: miklos@szeredi.hu, torvalds@osdl.org, davidm@snapgear.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] BDI: Provide backing device capability information [try #3]
Date: Wed, 09 Mar 2005 10:27:38 +0000 [thread overview]
Message-ID: <18569.1110364058@redhat.com> (raw)
In-Reply-To: <20050308163759.2ff4be57.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
> > The attached patch replaces backing_dev_info::memory_backed with
> > capabilitied bitmap.
>
> Looks sane to me, thanks.
>
> I hope you got all the conversions correct - breakage in the writeback
> dirty accounting manifests in subtle ways. I'll double-check it.
I think I got the logic as-was. This is quite easy to check just by looking at
the patch. However, the as-was logic should possibly be changed to reflect the
fact that the one control that there was has now been split into two.
David
prev parent reply other threads:[~2005-03-09 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050307121416.78381632.akpm@osdl.org>
[not found] ` <E1D8KPt-00058Y-00@dorka.pomaz.szeredi.hu>
[not found] ` <E1D8K3T-00056q-00@dorka.pomaz.szeredi.hu>
[not found] ` <20050307041047.59c24dec.akpm@osdl.org>
[not found] ` <20050307034747.4c6e7277.akpm@osdl.org>
[not found] ` <20050307033734.5cc75183.akpm@osdl.org>
[not found] ` <20050303123448.462c56cd.akpm@osdl.org>
[not found] ` <20050302135146.2248c7e5.akpm@osdl.org>
[not found] ` <20050302090734.5a9895a3.akpm@osdl.org>
[not found] ` <9420.1109778627@redhat.com>
[not found] ` <31789.1109799287@redhat.com>
[not found] ` <13767.1109857095@redhat.com>
[not found] ` <9268.1110194624@redhat.com>
[not found] ` <9741.1110195784@redhat.com>
[not found] ` <9947.1110196314@redhat.com>
[not found] ` <22447.1110204304@redhat.com>
[not found] ` <24382.1110210081@redhat.com>
[not found] ` <24862.1110211603@redhat.com>
[not found] ` <E1D8Ksv-0005Br-00@dorka.pomaz.szeredi.hu>
2005-03-08 14:12 ` [PATCH 1/2] BDI: Provide backing device capability information [try #3] David Howells
2005-03-09 0:37 ` Andrew Morton
2005-03-09 10:27 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18569.1110364058@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=davidm@snapgear.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).