From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 05/45] FS-Cache: Release page->private after failed
	readahead [ver #41]
Date: Fri, 21 Nov 2008 10:27:09 +0000
Message-ID: <18660.1227263229@redhat.com>
References: <20081121001237.a26cbe8f.akpm@linux-foundation.org>
	<20081120144139.10667.75519.stgit@warthog.procyon.org.uk>
	<20081120144205.10667.290.stgit@warthog.procyon.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org, dhowells@redhat.com,
	viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org
To: Andrew Morton <akpm@linux-foundation.org>
Return-path: <nfsv4-bounces@linux-nfs.org>
In-Reply-To: <20081121001237.a26cbe8f.akpm@linux-foundation.org>
List-Unsubscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=unsubscribe>
List-Archive: <http://linux-nfs.org/pipermail/nfsv4>
List-Post: <mailto:nfsv4@linux-nfs.org>
List-Help: <mailto:nfsv4-request@linux-nfs.org?subject=help>
List-Subscribe: <http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4>,
	<mailto:nfsv4-request@linux-nfs.org?subject=subscribe>
Sender: nfsv4-bounces@linux-nfs.org
Errors-To: nfsv4-bounces@linux-nfs.org
List-Id: linux-fsdevel.vger.kernel.org

Andrew Morton <akpm@linux-foundation.org> wrote:

> > +		if (TestSetPageLocked(page))
> 
> This got obsoleted by trylock_page().
> 
> I don't remember why, actually.

trylock_page() throws memory barriers in there on, say, PowerPC.  That's
probably necessary.

David