From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:62231 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbeDPQ6h (ORCPT ); Mon, 16 Apr 2018 12:58:37 -0400 Date: Mon, 16 Apr 2018 12:58:36 -0400 (EDT) From: Bob Peterson To: Souptick Joarder , Al Viro , linux-fsdevel Cc: swhiteho@redhat.com, cluster-devel@redhat.com, willy@infradead.org Message-ID: <187987639.19951308.1523897916628.JavaMail.zimbra@redhat.com> In-Reply-To: <20180414194155.GA20021@jordon-HP-15-Notebook-PC> References: <20180414194155.GA20021@jordon-HP-15-Notebook-PC> Subject: Re: [PATCH] fs: gfs2: Adding new return type vm_fault_t MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: ----- Original Message ----- > Use new return type vm_fault_t for page_mkwrite > handler. > > Signed-off-by: Souptick Joarder > Reviewed-by: Matthew Wilcox > --- > fs/gfs2/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c > index 4f88e20..2c471d6 100644 > --- a/fs/gfs2/file.c > +++ b/fs/gfs2/file.c > @@ -387,7 +387,7 @@ static int gfs2_allocate_page_backing(struct page *page) > * blocks allocated on disk to back that page. > */ > > -static int gfs2_page_mkwrite(struct vm_fault *vmf) > +static vm_fault_t gfs2_page_mkwrite(struct vm_fault *vmf) > { > struct page *page = vmf->page; > struct inode *inode = file_inode(vmf->vma->vm_file); > -- > 1.9.1 Hi, This patch is straightforward enough, but there are a lot of other file systems that need similar patches. Shouldn't you do one big patch set that fixes several file systems at once and run it through Viro's kernel or Linus's kernel or something? Adding Viro and linux-fsdevel for more opinions. Regards, Bob Peterson