From: David Howells <dhowells@redhat.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: Do we need DCACHE_WHITEOUT_TYPE?
Date: Mon, 18 Jun 2018 16:29:49 +0100 [thread overview]
Message-ID: <19226.1529335789@warthog.procyon.org.uk> (raw)
In-Reply-To: <20180618122709.2dims4vjfa26drb3@merlin>
Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
> There are some DCACHE_*_TYPE which are not used. I assume they were
> added during the development of overlayfs/unionfs and do not seem to
> make sense to keep.
Yes, Al started passing the patches for unionmounts upstream, then Linus went
and plonked overlayfs in there which broke unionmounts in a number of ways, so
these can be cleaned up.
(Though I suggest that overlayfs should probably set the DCACHE_WHITEOUT_TYPE
on whiteouts).
> Should we revert the following commits?
>
> 155e35d4daa8 ("VFS: Introduce inode-getting helpers for layered/unioned fs environments")
> e7f7d2253c05 ("VFS: Add a whiteout dentry type")
> df1a085af1f6 ("VFS: Add a fallthrough flag for marking virtual dentries")
The last one can definitely be reverted. The second one possibly, though
overlayfs should possibly be using it. The first one, I'm not sure - parts of
that overlayfs might be using.
> Are there any more commits related or during this merge which are not
> relevant anymore?
Possibly; I'll try and find some time to go through them.
David
prev parent reply other threads:[~2018-06-18 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 12:27 Do we need DCACHE_WHITEOUT_TYPE? Goldwyn Rodrigues
2018-06-18 15:29 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19226.1529335789@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox