From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710C0C87FDC for ; Wed, 7 Jun 2023 12:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240206AbjFGMLF (ORCPT ); Wed, 7 Jun 2023 08:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238739AbjFGMLD (ORCPT ); Wed, 7 Jun 2023 08:11:03 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3AD41BDC; Wed, 7 Jun 2023 05:10:33 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B2D7D1FDAB; Wed, 7 Jun 2023 12:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686139831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VqcjXu0CZTTpOZmrsxN0Wk6sBEC02dewC7QyNvd2soI=; b=IHfmh7S/uiagddCbXIRJmosPllrO40PYEOdRWLxIJcakAcNIU++BrgHVQz0wc7LcQAKKzC PPRnjWo+UKOWnOBcyWCCyUZkDBITx9Cp6jogvlX5nqnl/7EZ1E52mDDTaguTf4aV9jJ4YH Y0E8fz71thAZEe372iOj6DPRk6Att+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686139831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VqcjXu0CZTTpOZmrsxN0Wk6sBEC02dewC7QyNvd2soI=; b=MkcUMKJtjBchJhTKblNCrLqdAmaj8HslDTq0hIfVSuBi5J7Ox9FYzyAcm0vHDIQaJJ1iFw 8q1qSbcsmckQBWBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D65E13776; Wed, 7 Jun 2023 12:10:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m3hLGrdzgGTFOwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 12:10:31 +0000 Message-ID: <1b1e8640-7bc8-a213-9b6c-2eb0b843ece6@suse.de> Date: Wed, 7 Jun 2023 14:10:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 01/31] block: also call ->open for incremental partition opens Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-2-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 6/6/23 09:39, Christoph Hellwig wrote: > For whole devices ->open is called for each open, but for partitions it > is only called on the first open of a partition. This is problematic > as various block drivers look at open flags and might not do all setup > for ioctl only or NDELAY opens. > > Signed-off-by: Christoph Hellwig > --- > block/bdev.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes