[RESEND] [PATCH] linux/fs.h should include linux/path.h

[RESEND] [PATCH] linux/fs.h should include linux/path.h

[Niels de Vos]

<linux/fs.h> defines 'struct file' which uses 'struct path'. However
<linux/path.h> is not being included.

Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>

---
diff --git a/include/linux/fs.h b/include/linux/fs.h
index d8e2762..a14f1c4 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
 #include <linux/mutex.h>
 #include <linux/capability.h>
 #include <linux/semaphore.h>
+#include <linux/path.h>

 #include <asm/atomic.h>
 #include <asm/byteorder.h>

Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h

[Alexey Dobriyan]

On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
> <linux/path.h> is not being included.

> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
>  #include <linux/mutex.h>
>  #include <linux/capability.h>
>  #include <linux/semaphore.h>
> +#include <linux/path.h>

You see compilation breakage?

Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h

[Adrian Bunk]

On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
> <linux/path.h> is not being included.
> 
> Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
> 
> ---
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index d8e2762..a14f1c4 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
>  #include <linux/mutex.h>
>  #include <linux/capability.h>
>  #include <linux/semaphore.h>
> +#include <linux/path.h>
>...

This #include was recently added a few lines above.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h

[Niels de Vos]

On Sun, Jul 27, 2008 at 5:58 PM, Adrian Bunk <bunk@kernel.org> wrote:
> On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
>> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
>> <linux/path.h> is not being included.
>>
>> Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
>>
>> ---
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index d8e2762..a14f1c4 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
>>  #include <linux/mutex.h>
>>  #include <linux/capability.h>
>>  #include <linux/semaphore.h>
>> +#include <linux/path.h>
>>...
>
> This #include was recently added a few lines above.

Okay, looks like I've missed that commit.

Thanks, Niels