* [RESEND] [PATCH] linux/fs.h should include linux/path.h
@ 2008-07-27 12:34 Niels de Vos
2008-07-27 15:52 ` Alexey Dobriyan
2008-07-27 15:58 ` Adrian Bunk
0 siblings, 2 replies; 4+ messages in thread
From: Niels de Vos @ 2008-07-27 12:34 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel
<linux/fs.h> defines 'struct file' which uses 'struct path'. However
<linux/path.h> is not being included.
Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
---
diff --git a/include/linux/fs.h b/include/linux/fs.h
index d8e2762..a14f1c4 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -289,6 +289,7 @@ extern int dir_notify_enable;
#include <linux/mutex.h>
#include <linux/capability.h>
#include <linux/semaphore.h>
+#include <linux/path.h>
#include <asm/atomic.h>
#include <asm/byteorder.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h
2008-07-27 12:34 [RESEND] [PATCH] linux/fs.h should include linux/path.h Niels de Vos
@ 2008-07-27 15:52 ` Alexey Dobriyan
2008-07-27 15:58 ` Adrian Bunk
1 sibling, 0 replies; 4+ messages in thread
From: Alexey Dobriyan @ 2008-07-27 15:52 UTC (permalink / raw)
To: Niels de Vos; +Cc: linux-kernel, linux-fsdevel
On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
> <linux/path.h> is not being included.
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
> #include <linux/mutex.h>
> #include <linux/capability.h>
> #include <linux/semaphore.h>
> +#include <linux/path.h>
You see compilation breakage?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h
2008-07-27 12:34 [RESEND] [PATCH] linux/fs.h should include linux/path.h Niels de Vos
2008-07-27 15:52 ` Alexey Dobriyan
@ 2008-07-27 15:58 ` Adrian Bunk
2008-07-27 16:03 ` Niels de Vos
1 sibling, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2008-07-27 15:58 UTC (permalink / raw)
To: Niels de Vos; +Cc: linux-kernel, linux-fsdevel
On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
> <linux/path.h> is not being included.
>
> Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
>
> ---
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index d8e2762..a14f1c4 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
> #include <linux/mutex.h>
> #include <linux/capability.h>
> #include <linux/semaphore.h>
> +#include <linux/path.h>
>...
This #include was recently added a few lines above.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND] [PATCH] linux/fs.h should include linux/path.h
2008-07-27 15:58 ` Adrian Bunk
@ 2008-07-27 16:03 ` Niels de Vos
0 siblings, 0 replies; 4+ messages in thread
From: Niels de Vos @ 2008-07-27 16:03 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, linux-fsdevel, adobriyan
On Sun, Jul 27, 2008 at 5:58 PM, Adrian Bunk <bunk@kernel.org> wrote:
> On Sun, Jul 27, 2008 at 02:34:22PM +0200, Niels de Vos wrote:
>> <linux/fs.h> defines 'struct file' which uses 'struct path'. However
>> <linux/path.h> is not being included.
>>
>> Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
>>
>> ---
>> diff --git a/include/linux/fs.h b/include/linux/fs.h
>> index d8e2762..a14f1c4 100644
>> --- a/include/linux/fs.h
>> +++ b/include/linux/fs.h
>> @@ -289,6 +289,7 @@ extern int dir_notify_enable;
>> #include <linux/mutex.h>
>> #include <linux/capability.h>
>> #include <linux/semaphore.h>
>> +#include <linux/path.h>
>>...
>
> This #include was recently added a few lines above.
Okay, looks like I've missed that commit.
Thanks, Niels
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-27 16:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-27 12:34 [RESEND] [PATCH] linux/fs.h should include linux/path.h Niels de Vos
2008-07-27 15:52 ` Alexey Dobriyan
2008-07-27 15:58 ` Adrian Bunk
2008-07-27 16:03 ` Niels de Vos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).