From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 06/11] iov_iter: overlay struct iovec and ubuf/len
Date: Wed, 29 Mar 2023 14:01:01 -0600 [thread overview]
Message-ID: <1b9abd54-f046-af65-fd0c-1573e50c61d6@kernel.dk> (raw)
In-Reply-To: <CAHk-=wjMWpR6y34Rk92O31NFEOaZPuMb9DxwKThvFF-CE+vA8Q@mail.gmail.com>
On 3/29/23 1:59 PM, Linus Torvalds wrote:
> On Wed, Mar 29, 2023 at 12:56 PM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> Nope, still fails with it moved below.
>
> Ouch. I guess the 'const' cast may be the only way then. It sounds
> like gcc may warn whenever it sees an assignment to any structure that
> has a const member, rather than when it sees an assignment to that
> particular member.
>
> Sad.
Yeah, I tried a bunch of variants to trick it, including having
it in a union with another non-const iovec first. But it cannot be
tricked, so I think we're stuck with that. I'll add a comment.
--
Jens Axboe
next prev parent reply other threads:[~2023-03-29 20:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 18:40 [PATCHSET v6 0/11] Turn single segment imports into ITER_UBUF Jens Axboe
2023-03-29 18:40 ` [PATCH 01/11] block: ensure bio_alloc_map_data() deals with ITER_UBUF correctly Jens Axboe
2023-03-29 18:40 ` [PATCH 02/11] iov_iter: add iter_iovec() helper Jens Axboe
2023-03-29 18:40 ` [PATCH 03/11] iov_iter: add iter_iov_addr() and iter_iov_len() helpers Jens Axboe
2023-03-29 18:40 ` [PATCH 04/11] iov_iter: remove iov_iter_iovec() Jens Axboe
2023-03-29 18:40 ` [PATCH 05/11] iov_iter: set nr_segs = 1 for ITER_UBUF Jens Axboe
2023-03-29 18:40 ` [PATCH 06/11] iov_iter: overlay struct iovec and ubuf/len Jens Axboe
2023-03-29 19:30 ` Linus Torvalds
2023-03-29 19:38 ` Jens Axboe
2023-03-29 19:42 ` Jens Axboe
2023-03-29 19:49 ` Jens Axboe
2023-03-29 19:52 ` Linus Torvalds
2023-03-29 19:56 ` Jens Axboe
2023-03-29 19:59 ` Linus Torvalds
2023-03-29 20:01 ` Jens Axboe [this message]
2023-03-29 18:40 ` [PATCH 07/11] IB/hfi1: check for user backed iterator, not specific iterator type Jens Axboe
2023-03-29 18:40 ` [PATCH 08/11] IB/qib: " Jens Axboe
2023-03-29 18:40 ` [PATCH 09/11] ALSA: pcm: " Jens Axboe
2023-03-29 18:40 ` [PATCH 10/11] iov_iter: convert import_single_range() to ITER_UBUF Jens Axboe
2023-03-29 18:40 ` [PATCH 11/11] iov_iter: import single vector iovecs as ITER_UBUF Jens Axboe
2023-03-29 19:44 ` [PATCHSET v6 0/11] Turn single segment imports into ITER_UBUF Linus Torvalds
2023-03-29 19:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b9abd54-f046-af65-fd0c-1573e50c61d6@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).