From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: Miklos Szeredi <miklos@szeredi.hu>,
Joanne Koong <joannelkoong@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, josef@toxicpanda.com,
bernd.schubert@fastmail.fm, laoar.shao@gmail.com,
jlayton@kernel.org, senozhatsky@chromium.org, tfiga@chromium.org,
bgeffon@google.com, etmartin4313@gmail.com, kernel-team@meta.com
Subject: Re: [PATCH v11 0/2] fuse: add kernel-enforced request timeout option
Date: Fri, 17 Jan 2025 09:40:59 +0800 [thread overview]
Message-ID: <1dfcf698-2c85-458c-820a-ca9ec4d26de3@linux.alibaba.com> (raw)
In-Reply-To: <CAJfpegus1xAEABGnCgJN2CUF6L6=k1zHZ6eEAf8JqbwRdAJAMw@mail.gmail.com>
On 1/16/25 8:11 PM, Miklos Szeredi wrote:
> On Wed, 15 Jan 2025 at 20:41, Joanne Koong <joannelkoong@gmail.com> wrote:
>
>> Miklos, is this patchset acceptable for your tree?
>
> Looks good generally.
>
> I wonder why you chose to use a mount option instead of an FUSE_INIT param?
IMO this timeout mechanism has no dependence on the implementation on
the server side, and it's self-contained by the kernel side. Thus it's
adequate to negotiate through the mount option instead of the INIT
feature negotiation. Although the FUSE mount instance is generally
mounted by the fuse server itself in the libfuse implementation. IOW
INIT feature negotiation is required only when the server side shall opt in.
--
Thanks,
Jingbo
next prev parent reply other threads:[~2025-01-17 1:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 22:26 [PATCH v11 0/2] fuse: add kernel-enforced request timeout option Joanne Koong
2024-12-18 22:26 ` [PATCH v11 1/2] fuse: add kernel-enforced timeout option for requests Joanne Koong
2024-12-19 12:19 ` Jeff Layton
2024-12-19 14:06 ` Jeff Layton
2024-12-19 20:44 ` Etienne Martineau
2024-12-26 1:51 ` Sergey Senozhatsky
2024-12-18 22:26 ` [PATCH v11 2/2] fuse: add default_request_timeout and max_request_timeout sysctls Joanne Koong
2024-12-26 1:52 ` Sergey Senozhatsky
2025-01-15 19:41 ` [PATCH v11 0/2] fuse: add kernel-enforced request timeout option Joanne Koong
2025-01-16 12:11 ` Miklos Szeredi
2025-01-16 20:01 ` Joanne Koong
2025-01-17 1:40 ` Jingbo Xu [this message]
2025-01-17 19:05 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dfcf698-2c85-458c-820a-ca9ec4d26de3@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=bernd.schubert@fastmail.fm \
--cc=bgeffon@google.com \
--cc=etmartin4313@gmail.com \
--cc=jlayton@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox