From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4509EC6FD1D for ; Thu, 30 Mar 2023 08:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjC3IUj (ORCPT ); Thu, 30 Mar 2023 04:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230302AbjC3IUW (ORCPT ); Thu, 30 Mar 2023 04:20:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 120A71727 for ; Thu, 30 Mar 2023 01:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680164374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F6jCDp5R5UTDCRaJgvAusDHOREnAzeh37U4DgZVNJuM=; b=cAIrlPIG5njsVVlW0HKNysgG0csXoyGqeyhzugJ65zhvFwlFLwMV8RytU6XrFnu+riB10c ZWV8qf4mdCHh9bWSWXMn7q2iByjRzJ71eXe1JrgpmKG9rP5vkFIKtCjsrbmgGJaV3oV+Bn IWQbzLhKUCetZDwOJrsNX6lyfcaqTy4= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-GOgSTpdJOKW7Tx_pCT246A-1; Thu, 30 Mar 2023 04:19:32 -0400 X-MC-Unique: GOgSTpdJOKW7Tx_pCT246A-1 Received: by mail-ed1-f72.google.com with SMTP id s30-20020a508d1e000000b005005cf48a93so25886928eds.8 for ; Thu, 30 Mar 2023 01:19:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680164371; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F6jCDp5R5UTDCRaJgvAusDHOREnAzeh37U4DgZVNJuM=; b=dAnqvyFHToZTlw891uvSpaiGA9Ji58o9IuPckEgTdOnZS4XcveC79By6LttroaZaL7 PXyn5+cF2Iw4wk7Vnu3ymPpASyTuH+YPMB8KV8xW4bMcq+70mVzFrFsXozvfQQkHCTiQ BBuIcUZtQ40f+WrAxXtSgHWZ6SaO1US+I9exp7amEyEzcNSHTCku2Ta2i5+zaR40bupA BMZQyR0J3gRJz39aCcWavCwFZKDk6bA+bliqLlCKyPsF1qU/lJFHxLluKEQjNPuYjQ4P 66t1FPks/fxKQtzdUjlf5+4kgdTAWtPR3chsyIXc76ehgw2mFG6VUVabIgO8elwhV3tg t1Xw== X-Gm-Message-State: AAQBX9exYS6HsZPh51jUztSSkM6vYyx9IdQ60rp8V+LjwkvD6laIGsf8 gswDqK+TU1iZjX4CJjGmE6v3woAG9L+bInp5NuhmYfAzvB/hEE37RIh9trOHUxtJqebR8EoGD11 TI7KOoGLFhFOJGmTsijfmkLxYoA== X-Received: by 2002:aa7:ccc7:0:b0:4ac:b614:dd00 with SMTP id y7-20020aa7ccc7000000b004acb614dd00mr20695727edt.30.1680164371221; Thu, 30 Mar 2023 01:19:31 -0700 (PDT) X-Google-Smtp-Source: AKy350apSQp5MBlS/cA/cdZpOW4RsJ11da4ieQjuIibFRO7HEAy3t2ntlH34TjEdg6AUTexNtD9DcA== X-Received: by 2002:aa7:ccc7:0:b0:4ac:b614:dd00 with SMTP id y7-20020aa7ccc7000000b004acb614dd00mr20695718edt.30.1680164370986; Thu, 30 Mar 2023 01:19:30 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id v15-20020a50c40f000000b004d8d2735251sm18024701edf.43.2023.03.30.01.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Mar 2023 01:19:30 -0700 (PDT) Message-ID: <1e6460f9-5dbe-57a4-2986-ff3cbf5a39ad@redhat.com> Date: Thu, 30 Mar 2023 10:19:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] fs: vboxsf: remove unused out_len variable Content-Language: en-US, nl To: Tom Rix , nathan@kernel.org, ndesaulniers@google.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20230329230310.1816101-1-trix@redhat.com> From: Hans de Goede In-Reply-To: <20230329230310.1816101-1-trix@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi, On 3/30/23 01:03, Tom Rix wrote: > clang with W=1 reports > fs/vboxsf/utils.c:442:9: error: variable > 'out_len' set but not used [-Werror,-Wunused-but-set-variable] > size_t out_len; > ^ > This variable is not used so remove it. > > Signed-off-by: Tom Rix Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > fs/vboxsf/utils.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c > index dd0ae1188e87..ab0c9b01a0c2 100644 > --- a/fs/vboxsf/utils.c > +++ b/fs/vboxsf/utils.c > @@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, > { > const char *in; > char *out; > - size_t out_len; > size_t out_bound_len; > size_t in_bound_len; > > @@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, > in_bound_len = utf8_len; > > out = name; > - out_len = 0; > /* Reserve space for terminating 0 */ > out_bound_len = name_bound_len - 1; > > @@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, > > out += nb; > out_bound_len -= nb; > - out_len += nb; > } > > *out = 0;