From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: iget4/read_inode2 race in get_new_inode
Date: Mon, 29 Apr 2002 19:39:41 +0100
Sender: linux-fsdevel-owner@vger.kernel.org
Message-ID: <20020429193941.A25992@infradead.org>
References: <Pine.GSO.4.21.0204291342330.2918-100000@weyl.math.psu.edu> <20020429161430.GA3999@ravel.coda.cs.cmu.edu> <Pine.GSO.4.21.0204291342330.2918-100000@weyl.math.psu.edu> <5.1.0.14.2.20020429191445.049258b0@pop.cus.cam.ac.uk> <1020105046.16224.246.camel@jen.americas.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Anton Altaparmakov <aia21@cantab.net>,
	Jan Harkes <jaharkes@cs.cmu.edu>,
	Alexander Viro <viro@math.psu.edu>,
	linux-fsdevel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
To: Steve Lord <lord@sgi.com>
Content-Disposition: inline
In-Reply-To: <1020105046.16224.246.camel@jen.americas.sgi.com>; from lord@sgi.com on Mon, Apr 29, 2002 at 01:30:46PM -0500
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Apr 29, 2002 at 01:30:46PM -0500, Steve Lord wrote:
> Here for the record is that code - based by the way on some suggestions
> Al made here to Chris Mason about other ways of doing things than read_inode2
> 
> Any comments Al, and Anton, what were the cleanups and renames? The
> EXPORT_SYMBOL parts of this are missing right now, they should be in
> inode.c not ksyms.c where we currently have them.

 * kill ->read_inode2 entirely, reiserfs can be directly converted to
   icreate()
 * kill populate_inode, it is small and has only one user
 * either remove (_)unlock_new_inode entirely and let the callers do the
   two lines themselves or make it a #define in fs.h (unfortunately an
   inline isn't possible there due to missing wake_up() declaration)