Linux filesystem development
 help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Andrew Morton <akpm@digeo.com>, Hugh Dickins <hugh@veritas.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [patch] remove BKL from inode_setattr
Date: Mon, 14 Oct 2002 09:41:26 -0500	[thread overview]
Message-ID: <200210140941.26157.shaggy@austin.ibm.com> (raw)
In-Reply-To: <3DAA6587.2A4C24B0@digeo.com>

On Monday 14 October 2002 01:34, Andrew Morton wrote:

> --- 2.5.42/fs/jfs/file.c~truncate-bkl	Sun Oct 13 21:11:06 2002
> +++ 2.5.42-akpm/fs/jfs/file.c	Sun Oct 13 21:11:11 2002
> @@ -18,6 +18,7 @@
>   */
>
>  #include <linux/fs.h>
> +#include <linux/smp_lock.h>
>  #include "jfs_incore.h"
>  #include "jfs_dmap.h"
>  #include "jfs_txnmgr.h"
> @@ -90,9 +91,11 @@ static void jfs_truncate(struct inode *i
>  {
>  	jFYI(1, ("jfs_truncate: size = 0x%lx\n", (ulong) ip->i_size));
>
> +	lock_kernel();
>  	IWRITE_LOCK(ip);
>  	jfs_truncate_nolock(ip, ip->i_size);
>  	IWRITE_UNLOCK(ip);
> +	unlock_kernel();
>  }
>
>  static int jfs_open(struct inode *inode, struct file *file)

JFS does not need the BKL.  It does it's own locking.

-- 
David Kleikamp
IBM Linux Technology Center


      parent reply	other threads:[~2002-10-14 14:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-14  5:02 [patch] remove BKL from inode_setattr Andrew Morton
2002-10-14  6:09 ` Hugh Dickins
2002-10-14  6:34   ` Andrew Morton
2002-10-14 14:07     ` Steve Lord
2002-10-14 16:41       ` Andrew Morton
2002-10-14 16:49         ` Steve Lord
2002-10-14 14:41     ` Dave Kleikamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210140941.26157.shaggy@austin.ibm.com \
    --to=shaggy@austin.ibm.com \
    --cc=akpm@digeo.com \
    --cc=hugh@veritas.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox