readdir within kernel

[Herbert Poetzl <herbert@13thfloor.at>]

hi all!

I would like to know if this is the right way to
read a directory contents for a given directory
dentry within a kernel module ...

suggestions and/or hints are very welcome ...


extern	filldir_t xxx_filler;


void	xxx_dump_dir(struct dentry *de)
{
    	struct file pf;
	struct inode *in = de->d_inode;
	int ret;	
		
	ret = init_private_file(&pf, de, FMODE_READ);
	if (!pf.f_op->readdir)
		goto out_close;
		
    	ret = vfs_readdir(&pf, xxx_filler, (void *)0);

out_close:
	if (pf.f_op->release)
		pf.f_op->release(in, &pf);
    	return;
}

many thanks,
Herbert