From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dilger Subject: Re: [PATCH] backout the xattr override access checks flag Date: Thu, 20 Feb 2003 13:20:58 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030220132058.E1723@schatzie.adilger.int> References: <20030220222007.A21678@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: torvalds@transmeta.com, agruen@suse.de, linux-fsdevel@vger.kernel.org Return-path: To: Christoph Hellwig Content-Disposition: inline In-Reply-To: <20030220222007.A21678@sgi.com>; from hch@sgi.com on Thu, Feb 20, 2003 at 10:20:07PM -0500 List-Id: linux-fsdevel.vger.kernel.org On Feb 20, 2003 22:20 -0500, Christoph Hellwig wrote: > - if (!((flags & XATTR_KERNEL_CONTEXT) || capable(CAP_SYS_ADMIN))) > + if (!capable(CAP_SYS_ADMIN)) How about using CAP_DAC_OVERRIDE instead of CAP_SYS_ADMIN, since the latter is _way_ over used, and basically amounts to a uid=0 test these days. Cheers, Andreas -- Andreas Dilger http://sourceforge.net/projects/ext2resize/ http://www-mddsp.enel.ucalgary.ca/People/adilger/