From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@sgi.com>,
torvalds@transmeta.com, agruen@suse.de,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] backout the xattr override access checks flag
Date: Thu, 20 Feb 2003 20:26:21 +0000 [thread overview]
Message-ID: <20030220202621.A11571@infradead.org> (raw)
In-Reply-To: <20030220132058.E1723@schatzie.adilger.int>; from adilger@clusterfs.com on Thu, Feb 20, 2003 at 01:20:58PM -0700
On Thu, Feb 20, 2003 at 01:20:58PM -0700, Andreas Dilger wrote:
> On Feb 20, 2003 22:20 -0500, Christoph Hellwig wrote:
> > - if (!((flags & XATTR_KERNEL_CONTEXT) || capable(CAP_SYS_ADMIN)))
> > + if (!capable(CAP_SYS_ADMIN))
>
> How about using CAP_DAC_OVERRIDE instead of CAP_SYS_ADMIN, since the
> latter is _way_ over used, and basically amounts to a uid=0 test these
> days.
It's not a DAC override strictly spoken. But I agree with you that it
shouldn't be CAP_SYS_ADMIN (see my previous discussion with Andreas).
Neverless this is purely a change to backout the flags change and I don't
want to mix up too much.
next prev parent reply other threads:[~2003-02-20 20:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-21 3:20 [PATCH] backout the xattr override access checks flag Christoph Hellwig
2003-02-20 20:20 ` Andreas Dilger
2003-02-20 20:26 ` Christoph Hellwig [this message]
2003-02-21 10:20 ` Andreas Gruenbacher
2003-02-21 15:54 ` Christoph Hellwig
2003-02-21 16:32 ` Andreas Gruenbacher
-- strict thread matches above, loose matches on Subject: below --
2003-02-21 12:50 Luka Renko
2003-02-21 15:58 ` Christoph Hellwig
2003-02-23 19:28 Luka Renko
2003-02-23 19:36 ` Christoph Hellwig
2003-02-23 22:16 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030220202621.A11571@infradead.org \
--to=hch@infradead.org \
--cc=agruen@suse.de \
--cc=hch@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).