From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] backout the xattr override access checks flag
Date: Thu, 20 Feb 2003 20:26:21 +0000
Sender: linux-fsdevel-owner@vger.kernel.org
Message-ID: <20030220202621.A11571@infradead.org>
References: <20030220222007.A21678@sgi.com> <20030220132058.E1723@schatzie.adilger.int>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-fsdevel-owner@vger.kernel.org>
To: Christoph Hellwig <hch@sgi.com>, torvalds@transmeta.com,
	agruen@suse.de, linux-fsdevel@vger.kernel.org
Content-Disposition: inline
In-Reply-To: <20030220132058.E1723@schatzie.adilger.int>; from adilger@clusterfs.com on Thu, Feb 20, 2003 at 01:20:58PM -0700
List-Id: linux-fsdevel.vger.kernel.org

On Thu, Feb 20, 2003 at 01:20:58PM -0700, Andreas Dilger wrote:
> On Feb 20, 2003  22:20 -0500, Christoph Hellwig wrote:
> > -	if (!((flags & XATTR_KERNEL_CONTEXT) || capable(CAP_SYS_ADMIN)))
> > +	if (!capable(CAP_SYS_ADMIN))
> 
> How about using CAP_DAC_OVERRIDE instead of CAP_SYS_ADMIN, since the
> latter is _way_ over used, and basically amounts to a uid=0 test these
> days.

It's not a DAC override strictly spoken.  But I agree with you that it
shouldn't be CAP_SYS_ADMIN (see my previous discussion with Andreas).

Neverless this is purely a change to backout the flags change and I don't
want to mix up too much.