From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andries Brouwer Subject: Re: handling unrecognised mount options Date: Sun, 16 Mar 2003 12:50:26 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030316115026.GA7674@win.tue.nl> References: <20030316030003.21f2942b.akpm@digeo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net Return-path: To: Andrew Morton Content-Disposition: inline In-Reply-To: <20030316030003.21f2942b.akpm@digeo.com> List-Id: linux-fsdevel.vger.kernel.org On Sun, Mar 16, 2003 at 03:00:03AM -0800, Andrew Morton wrote: > None of my machines will successfully boot into 2.4 kernels because I have > "commit=30" added to the ext3 mount options in /etc/fstab. > > The ext3 driver in those kernels does not to recognise that option and it > fails the mount. > > This seems to be a fairly gratuitous and pointless forward-incompatibility. > > I propose that henceforth filesystems will, when presented with an > unrecognised mount option, warn and proceed with the mount anyway. > > Can anyone see any problems with that? I would prefer the conservative approach, doing the mount only when also some "force" flag is present. Mounting is a dangerous operation. An incorrect mount can crash the kernel and can damage the filesystem. Andries