From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: handling unrecognised mount options Date: Sun, 16 Mar 2003 14:46:24 -0800 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030316144624.69060b84.akpm@digeo.com> References: <20030316030003.21f2942b.akpm@digeo.com> <20030316115026.GA7674@win.tue.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net Return-path: Received: from digeo-nav01.digeo.com (digeo-nav01 [192.168.1.233]) by packet.digeo.com (8.12.8/8.12.8) with SMTP id h2GMkKPv012937 for ; Sun, 16 Mar 2003 14:46:23 -0800 (PST) To: Andries Brouwer In-Reply-To: <20030316115026.GA7674@win.tue.nl> List-Id: linux-fsdevel.vger.kernel.org Andries Brouwer wrote: > > On Sun, Mar 16, 2003 at 03:00:03AM -0800, Andrew Morton wrote: > > > None of my machines will successfully boot into 2.4 kernels because I have > > "commit=30" added to the ext3 mount options in /etc/fstab. > > > > The ext3 driver in those kernels does not to recognise that option and it > > fails the mount. > > > > This seems to be a fairly gratuitous and pointless forward-incompatibility. > > > > I propose that henceforth filesystems will, when presented with an > > unrecognised mount option, warn and proceed with the mount anyway. > > > > Can anyone see any problems with that? > > I would prefer the conservative approach, doing the mount only > when also some "force" flag is present. > > Mounting is a dangerous operation. > An incorrect mount can crash the kernel and can damage the filesystem. > The only way we could have a problem here is if someone made a back-incompatible change to a filesystem format which would cause problems for older kernels. And then _required_ that newer kernel be given this mount option. I just cannot think of any other scenario in which the current behaviour makes sense. And it is objectionable. Certainly it does not make sense for ext2 and ext3 where we have compatibility flags for these things. So I'm at least looking for an argument aganst changing this behaviour for ext2/3.