From mboxrd@z Thu Jan 1 00:00:00 1970 From: Livio Baldini Soares Subject: Re: Race with inodes in I_FREEING state Date: Fri, 13 Jun 2003 10:00:27 -0300 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030613130026.GA17572@ime.usp.br> References: <20030613034445.GA8074@ime.usp.br> <16105.23298.943826.574004@gargle.gargle.HOWL> <20030613013547.A26944@schatzie.adilger.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Neil Brown , linux-fsdevel@vger.kernel.org Return-path: Received: from birosca.ime.usp.br ([143.107.45.59]:62656 "HELO birosca.ime.usp.br") by vger.kernel.org with SMTP id S265379AbTFMMqm (ORCPT ); Fri, 13 Jun 2003 08:46:42 -0400 To: Andreas Dilger Content-Disposition: inline In-Reply-To: <20030613013547.A26944@schatzie.adilger.int> List-Id: linux-fsdevel.vger.kernel.org Hey! Andreas Dilger writes: > On Jun 13, 2003 15:02 +1000, Neil Brown wrote: > > > On Friday June 13, livio@ime.usp.br wrote: [...] > > > Does this not also happen in version 2.4.20? Can anybody tell me if > > > my logic is wrong, or if I'm just plain doing something stupid in my > > > FS? > > > > Yep. It sound like the same race. I wasn't going to submit a 2.4 > > patch until the 2.5 one went in. I hope to submit the 2.4 equivalent > > when 2.4.22-pre opens up. Ah, _great_! Thanks a lot Niel. > Sigh, we've just spent a week chasing exactly this same race in Lustre > on 2.4. It also stores pointers to shared data in the inode (DLM locks) > which are freed when clear_inode() is called. We fixed it only a few > hours ago by not matching our hashed locks if they are not for the same > inode _pointer_ instead of just for the same inode _number_/generation, > which is what the distributed lock name is. Humm.. interesting work around. Except, my FS, the hashed data I have in the inode's private parts has no idea that an inode even _exists_. Guess I'll have to start keeping a back pointer to the inode, until this is fixed. Darn. > If only Livio had posted this email last week ;-). Oops, sorry about that! :-P But you too, could of sent this earlier and saved me 2 days of doing absolutely nothing except looking into a monitor ;-) Cheers!! -- Livio B. Soares