From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: [PATCH] remove TCGETS Date: Tue, 12 Aug 2003 22:48:02 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030812214802.GM10015@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:45000 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S271156AbTHLVsE (ORCPT ); Tue, 12 Aug 2003 17:48:04 -0400 To: intermezzo-devel@lists.sf.net Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org I see no reason to handle TCGETS in presto_ioctl, and even if you do get it somehow, the action is the same as the default. This happens to break on PA-RISC and not on i386 due to i386 using an old-style definition of TCGETS and PA-RISC using one which invovles sizeof(). diff -urpNX dontdiff linus-2.6/fs/intermezzo/dir.c parisc-2.6/fs/intermezzo/dir.c --- linus-2.6/fs/intermezzo/dir.c Tue Aug 12 13:11:17 2003 +++ parisc-2.6/fs/intermezzo/dir.c Tue Aug 12 13:29:43 2003 @@ -1304,10 +1304,6 @@ int presto_ioctl(struct inode *inode, st return rc; } - case TCGETS: - EXIT; - return -EINVAL; - default: EXIT; return -EINVAL; -- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk