From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH] remove TCGETS Date: Thu, 14 Aug 2003 02:43:45 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20030814014345.GH10015@parcelfarce.linux.theplanet.co.uk> References: <20030812214802.GM10015@parcelfarce.linux.theplanet.co.uk> <20030812155956.C3708@schatzie.adilger.int> <1060776724.2226.49.camel@passion.cambridge.redhat.com> <20030813093521.F3708@schatzie.adilger.int> <20030814012818.GD1918@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Woodhouse , Matthew Wilcox , intermezzo-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:40380 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S272127AbTHNBns (ORCPT ); Wed, 13 Aug 2003 21:43:48 -0400 To: Peter Braam Content-Disposition: inline In-Reply-To: <20030814012818.GD1918@localhost.localdomain> List-Id: linux-fsdevel.vger.kernel.org On Wed, Aug 13, 2003 at 07:28:18PM -0600, Peter Braam wrote: > In fact some part of POSIX says that ioctls should return EINVAL > that's why I made that choice. Anyway, the issue is moot. Actually, it's an interesting point. The relevant bit of SUSv3 says: If an underlying device driver detects an error, then ioctl() shall fail if: [EINVAL] The request or arg argument is not valid for this device. [EIO] Some physical I/O error has occurred. [ENOTTY] The fildes argument is not associated with a STREAMS device that accepts control functions. [ENXIO] The request and arg arguments are valid for this device driver, but the service requested cannot be performed on this particular sub-device. [ENODEV] The fildes argument refers to a valid STREAMS device, but the corresponding device driver does not support the ioctl() function. SUSv2 agrees: http://www.opengroup.org/onlinepubs/007908799/xsh/ioctl.html Maybe we need to start removing ENOTTY returns from ioctl handlers. I know, we all find it funny when we're told that something isn't a typewriter, but ... -- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk