From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J.A. Magallon" Subject: Re: [ANNOUNCE] new HFS(+) driver Date: Sat, 4 Oct 2003 00:39:04 +0200 Sender: linux-hfsplus-devel-admin=5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Message-ID: <20031003223904.GE30751@werewolf.able.es> References: <20031003070422.GA8627@werewolf.able.es> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: "J.A. Magallon" , linux-hfsplus-devel=5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-fsdevel=u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel=u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: To: Roman Zippel Content-Disposition: inline In-Reply-To: (from zippel@linux-m68k.org on Fri, Oct 03, 2003 at 12:30:36 +0200) Errors-To: linux-hfsplus-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: linux-fsdevel.vger.kernel.org On 10.03, Roman Zippel wrote: > Hi, > > On Fri, 3 Oct 2003, J.A. Magallon wrote: > > > Two notes: > > - You should give a patch or at least give a notice that linux/include/hfs* have > > to be killed (or move hfs_fs.h there). > > You did apply linux-2.4.hfs.diff? I don't understand why you had to move > hfs_fs.h, it should be picked up from the current directory. > I applied it, it just keeps mainstream files from including old hfs* files in include/linux, but the old files stay around (you end with two versions of hfs_fs.h, one in include/linux and other in fs/hfs...) I did not move anything, just deleted those old files. But as other filesystems put their xxxx_fs.h in include/linux, I thought that perhaps hfs(plus) should do the same. > > - I had to include linux/sched.h in hfs/sysdep.c to get the definition for > > 'current', that was neded in some subinclude of linux/smp_lock. This can be > > caused by any other of my patches, but it doesn't hurt. > > Simply move past "hfs_fs.h". > Thanks. -- J.A. Magallon \ Software is like sex: werewolf!able!es \ It's better when it's free Mandrake Linux release 9.2 (Cooker) for i586 Linux 2.4.23-pre6-jam1 (gcc 3.3.1 (Mandrake Linux 9.2 3.3.1-2mdk)) ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf