Linux filesystem development
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: "Joseph D. Wagner" <theman@josephdwagner.info>,
	linux-fsdevel@vger.kernel.org
Subject: Re: Does mandatory locking need to be set when the file is locked?
Date: Mon, 15 Dec 2003 18:59:25 +0000	[thread overview]
Message-ID: <20031215185925.GK15674@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <shswu8yj6m0.fsf@guts.uio.no>

On Mon, Dec 15, 2003 at 01:09:11PM -0500, Trond Myklebust wrote:
> Finally, the Linux mandatory locking implementation does not eliminate
> all possible races: currently there is no attempt made to exclude one
> thread from taking a lock while another is still in the process of
> writing to the file, or if it already has a section of that file
> mmapped. In that case, the lock call may well succeed, but the
> other thread that is inside read/write/mmap will not see it.
> 
> So if you want to DEPEND on mandatory locking to work, then you
> probably have some kernel debugging to do first.

And fixing these problems requires some pretty invasive work to
current hot code paths like read/write/mmap/open/close.  When I started
investigating it, I was told the additional overhead for my scheme was
unacceptable and to just forget about it because nobody really used
mandatory locks anyway.

That was enough to put me off.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  reply	other threads:[~2003-12-15 18:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-15  1:57 Does mandatory locking need to be set when the file is locked? Joseph D. Wagner
2003-12-15 15:38 ` Matthew Wilcox
2003-12-15 15:50   ` Joseph D. Wagner
2003-12-15 16:23     ` Randy.Dunlap
2003-12-15 18:09     ` Trond Myklebust
2003-12-15 18:59       ` Matthew Wilcox [this message]
2003-12-16 19:13         ` Bryan Henderson
2003-12-16 20:33           ` Mike Fedyk
2003-12-16 21:48             ` Trond Myklebust
2003-12-16 22:00               ` Mike Fedyk
2003-12-15 17:05 ` Bryan Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031215185925.GK15674@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=theman@josephdwagner.info \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox