From: Jan Kara <jack@suse.cz>
To: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: missing inode_add_bytes in dquot_alloc_space
Date: Thu, 15 Jan 2004 09:43:41 +0100 [thread overview]
Message-ID: <20040115084341.GH27549@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <1074097629.17479.66.camel@shaggy.austin.ibm.com>
Hi,
> I don't think it was intentional, but in dquot_alloc_space, if
> IS_NOQUOTA(inode) is true, then i_blocks doesn't get updated. This
> patch would fix it to do what I believe it should. Is this right, or am
> I missing something?
Good spotting. Thanks. Actually the same problem is at other functions
(dquot_free_space(), etc.). I'll fix it completely in the afternoon.
Thanks for spotting
Honza
next prev parent reply other threads:[~2004-01-15 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 16:27 missing inode_add_bytes in dquot_alloc_space Dave Kleikamp
2004-01-15 8:43 ` Jan Kara [this message]
2004-01-16 11:20 ` Jan Kara
2004-01-16 12:19 ` Christoph Hellwig
2004-01-16 13:33 ` Jan Kara
2004-01-16 13:57 ` Christoph Hellwig
2004-01-16 13:37 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040115084341.GH27549@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).