From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: missing inode_add_bytes in dquot_alloc_space Date: Thu, 15 Jan 2004 09:43:41 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040115084341.GH27549@atrey.karlin.mff.cuni.cz> References: <1074097629.17479.66.camel@shaggy.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: fsdevel Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:18071 "EHLO atrey.karlin.mff.cuni.cz") by vger.kernel.org with ESMTP id S266565AbUAOInn (ORCPT ); Thu, 15 Jan 2004 03:43:43 -0500 To: Dave Kleikamp Content-Disposition: inline In-Reply-To: <1074097629.17479.66.camel@shaggy.austin.ibm.com> List-Id: linux-fsdevel.vger.kernel.org Hi, > I don't think it was intentional, but in dquot_alloc_space, if > IS_NOQUOTA(inode) is true, then i_blocks doesn't get updated. This > patch would fix it to do what I believe it should. Is this right, or am > I missing something? Good spotting. Thanks. Actually the same problem is at other functions (dquot_free_space(), etc.). I'll fix it completely in the afternoon. Thanks for spotting Honza