From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>,
fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: missing inode_add_bytes in dquot_alloc_space
Date: Fri, 16 Jan 2004 12:19:49 +0000 [thread overview]
Message-ID: <20040116121949.A23101@infradead.org> (raw)
In-Reply-To: <20040116112028.GA28501@atrey.karlin.mff.cuni.cz>; from jack@suse.cz on Fri, Jan 16, 2004 at 12:20:28PM +0100
On Fri, Jan 16, 2004 at 12:20:28PM +0100, Jan Kara wrote:
> down_read(&sb_dqopt(inode->i_sb)->dqptr_sem);
> - if (IS_NOQUOTA(inode)) {
> - up_read(&sb_dqopt(inode->i_sb)->dqptr_sem);
> - return QUOTA_OK;
> - }
> spin_lock(&dq_data_lock);
> + if (IS_NOQUOTA(inode))
> + goto add_bytes;
This means we take a global lock now even for non-quota operations?
Doesn't sound like a really good idea..
next prev parent reply other threads:[~2004-01-16 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 16:27 missing inode_add_bytes in dquot_alloc_space Dave Kleikamp
2004-01-15 8:43 ` Jan Kara
2004-01-16 11:20 ` Jan Kara
2004-01-16 12:19 ` Christoph Hellwig [this message]
2004-01-16 13:33 ` Jan Kara
2004-01-16 13:57 ` Christoph Hellwig
2004-01-16 13:37 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116121949.A23101@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).