From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: missing inode_add_bytes in dquot_alloc_space
Date: Fri, 16 Jan 2004 12:19:49 +0000
Sender: linux-fsdevel-owner@vger.kernel.org
Message-ID: <20040116121949.A23101@infradead.org>
References: <1074097629.17479.66.camel@shaggy.austin.ibm.com> <20040116112028.GA28501@atrey.karlin.mff.cuni.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dave Kleikamp <shaggy@austin.ibm.com>,
	fsdevel <linux-fsdevel@vger.kernel.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from phoenix.infradead.org ([213.86.99.234]:9235 "EHLO
	phoenix.infradead.org") by vger.kernel.org with ESMTP
	id S265441AbUAPMTz (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 16 Jan 2004 07:19:55 -0500
To: Jan Kara <jack@suse.cz>
Content-Disposition: inline
In-Reply-To: <20040116112028.GA28501@atrey.karlin.mff.cuni.cz>; from jack@suse.cz on Fri, Jan 16, 2004 at 12:20:28PM +0100
List-Id: linux-fsdevel.vger.kernel.org

On Fri, Jan 16, 2004 at 12:20:28PM +0100, Jan Kara wrote:
>  	down_read(&sb_dqopt(inode->i_sb)->dqptr_sem);
> -	if (IS_NOQUOTA(inode)) {
> -		up_read(&sb_dqopt(inode->i_sb)->dqptr_sem);
> -		return QUOTA_OK;
> -	}
>  	spin_lock(&dq_data_lock);
> +	if (IS_NOQUOTA(inode))
> +		goto add_bytes;

This means we take a global lock now even for non-quota operations?
Doesn't sound like a really good idea..