From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH] ext3 [linux-2.6.2.]: accessing already freed inodes when under memory pressure Date: Thu, 19 Feb 2004 21:19:53 +0100 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <200402192119.57078.cotte@freenet.de> References: <200402191321.39592.cotte@freenet.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: linux-fsdevel@vger.kernel.org, Andrew Morton , "Stephen C. Tweedie" , schwidefsky@de.ibm.com, cotte@de.ibm.com Return-path: Received: from mout2.freenet.de ([194.97.50.155]:8934 "EHLO mout2.freenet.de") by vger.kernel.org with ESMTP id S267541AbUBSUQN convert rfc822-to-8bit (ORCPT ); Thu, 19 Feb 2004 15:16:13 -0500 To: Linus Torvalds In-Reply-To: Content-Description: clearsigned data Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org Am Donnerstag 19 Februar 2004 17:53 schrieb Linus Torvalds: > I really think this is wrong. The bug is clearly in ext3 reference count > handling, and I'd much rather just have ext3 fix its reference count than > add a totally new interface for ext3 breakage. I do agree that the final patch fixing the problem should not add a new interface. This one clearly should not go into vanilla, but consider adding the BUG_ON statement at least for the time being until there is a real fix. diff -ruN linux-2.6.2/fs/ext3/super.c linux-2.6.2+bug_statement/fs/ext3/super.c --- linux-2.6.2/fs/ext3/super.c 2004-02-19 12:52:01.000000000 +0100 +++ linux-2.6.2+bug_statement/fs/ext3/super.c 2004-02-19 12:51:35.000000000 +0100 @@ -449,6 +449,7 @@ static void ext3_destroy_inode(struct inode *inode) { + BUG_ON (!list_empty(&EXT3_I(inode)->i_orphan)); kmem_cache_free(ext3_inode_cachep, EXT3_I(inode)); }