From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: Does struct qstr->name should be terminated ? Date: Wed, 24 Mar 2004 13:05:34 +0000 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040324130534.GH25059@parcelfarce.linux.theplanet.co.uk> References: <406017C1.4080005@free.fr> <20040324090926.GE28822@vagabond> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jerome de Vivie , linux-fsdevel@vger.kernel.org Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:53229 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263338AbUCXNFf (ORCPT ); Wed, 24 Mar 2004 08:05:35 -0500 To: Jan Hudec Content-Disposition: inline In-Reply-To: <20040324090926.GE28822@vagabond> List-Id: linux-fsdevel.vger.kernel.org On Wed, Mar 24, 2004 at 10:09:26AM +0100, Jan Hudec wrote: > I'd think that it's treated as a nomral string in quite a few places, so > it needs to be NUL terminated. (But not searched the sources.) Why not? It isn't hard to find. fs/dcache.c:703: str[name->len] = 0; -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain