From mboxrd@z Thu Jan 1 00:00:00 1970 From: viro@parcelfarce.linux.theplanet.co.uk Subject: Re: fcntl method for file_operations Date: Thu, 25 Mar 2004 20:34:48 +0000 Sender: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org Message-ID: <20040325203448.GY31500@parcelfarce.linux.theplanet.co.uk> References: <1080237894.2380.5.camel@stevef95.austin.ibm.com> <20040325193545.GC25059@parcelfarce.linux.theplanet.co.uk> <1080246358.3200.45.camel@stevef95.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Matthew Wilcox , linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org, Jamie Lokier Return-path: To: Steve French Content-Disposition: inline In-Reply-To: <1080246358.3200.45.camel@stevef95.austin.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Mar 25, 2004 at 02:25:58PM -0600, Steve French wrote: > passed to network filesystems and filesystems without true block > devices. Current sys_quotactl does > bdev = lookup_bdev(name) > then > get_super(bdev) > > rather than looking up the superblock directly from the name (using > user_path_walk as sys_statfs and other places in the kernel do) so that > small section of quota.c needs to be modified for non-local and > deviceless filesystems. That's not a VFS problem - it's a bad syscall API. Note that statfs(2) uses pathname of mountpoint (anything on fs, actually). quotactl(2) uses pathname of _device_. Which is, indeed, a bad idea, but we are tied by user-visible API here.