[PATCH] ncpfs data corruption when using large TCP transfers

[PATCH] ncpfs data corruption when using large TCP transfers

[Petr Vandrovec]

Hi,
  

ncpfs was forgetting to update iovec's iov_base field whenever partial 
transmission occured. This was causing data corruption during large 
(60kB) writes.

Code now also passes copy of iovec to the sock_sendmsg, so it does not
rely on network stack updating (or not updating) passed iovec in case of
success (or failure).

						Thanks,
							Petr Vandrovec

diff -urdN linux/fs/ncpfs/sock.c linux/fs/ncpfs/sock.c
--- linux/fs/ncpfs/sock.c	2004-04-30 23:23:04.000000000 +0000
+++ linux/fs/ncpfs/sock.c	2004-05-05 19:51:07.000000000 +0000
@@ -205,17 +205,20 @@
 	struct ncp_request_reply *rq;
 	struct msghdr msg;
 	struct iovec* iov;
+	struct iovec iovc[3];
 	int result;
 
 	rq = server->tx.creq;
 	if (!rq) {
 		return;
 	}
-
+
+	/* sock_sendmsg updates iov pointers for us :-( */
+	memcpy(iovc, rq->tx_ciov, rq->tx_iovlen * sizeof(iov[0]));
 	msg.msg_name = NULL;
 	msg.msg_namelen = 0;
 	msg.msg_control = NULL;
-	msg.msg_iov = rq->tx_ciov;
+	msg.msg_iov = iovc;
 	msg.msg_iovlen = rq->tx_iovlen;
 	msg.msg_flags = MSG_NOSIGNAL | MSG_DONTWAIT;
 	result = sock_sendmsg(server->ncp_sock, &msg, rq->tx_totallen);
@@ -239,6 +242,7 @@
 		iov++;
 		rq->tx_iovlen--;
 	}
+	iov->iov_base += result;
 	iov->iov_len -= result;
 	rq->tx_ciov = iov;
 }