From: Christoph Hellwig <hch@lst.de>
To: linux-fsdevel@vger.kernel.org
Subject: RFC: filenames without periods in isofs
Date: Sun, 23 May 2004 01:49:24 +0200 [thread overview]
Message-ID: <20040522234924.GB3898@infradead.org> (raw)
currently isofs marks filenames witout periods as executable which is
rather odd. The Debian kernel package has an old patch to sanitize this
behaviour and I wonder whether we should get it into mainline.
* Removed period check for executables in fs/isofs/inode.c
--- kernel-source-2.6.6/fs/isofs/inode.c 2004-05-10 19:48:03.000000000 +1000
+++ kernel-source-2.6.6-1/fs/isofs/inode.c 2004-05-10 22:21:47.000000000 +1000
@@ -1250,14 +1250,6 @@
inode->i_mode = sbi->s_mode;
inode->i_nlink = 1;
inode->i_mode |= S_IFREG;
- /* If there are no periods in the name,
- * then set the execute permission bit
- */
- for(i=0; i< de->name_len[0]; i++)
- if(de->name[i]=='.' || de->name[i]==';')
- break;
- if(i == de->name_len[0] || de->name[i] == ';')
- inode->i_mode |= S_IXUGO; /* execute permission */
}
inode->i_uid = sbi->s_uid;
inode->i_gid = sbi->s_gid;
reply other threads:[~2004-05-22 23:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040522234924.GB3898@infradead.org \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).