* RFC: filenames without periods in isofs
@ 2004-05-22 23:49 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2004-05-22 23:49 UTC (permalink / raw)
To: linux-fsdevel
currently isofs marks filenames witout periods as executable which is
rather odd. The Debian kernel package has an old patch to sanitize this
behaviour and I wonder whether we should get it into mainline.
* Removed period check for executables in fs/isofs/inode.c
--- kernel-source-2.6.6/fs/isofs/inode.c 2004-05-10 19:48:03.000000000 +1000
+++ kernel-source-2.6.6-1/fs/isofs/inode.c 2004-05-10 22:21:47.000000000 +1000
@@ -1250,14 +1250,6 @@
inode->i_mode = sbi->s_mode;
inode->i_nlink = 1;
inode->i_mode |= S_IFREG;
- /* If there are no periods in the name,
- * then set the execute permission bit
- */
- for(i=0; i< de->name_len[0]; i++)
- if(de->name[i]=='.' || de->name[i]==';')
- break;
- if(i == de->name_len[0] || de->name[i] == ';')
- inode->i_mode |= S_IXUGO; /* execute permission */
}
inode->i_uid = sbi->s_uid;
inode->i_gid = sbi->s_gid;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-05-22 23:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-22 23:49 RFC: filenames without periods in isofs Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).