From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: RFC: filenames without periods in isofs Date: Sun, 23 May 2004 01:49:24 +0200 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <20040522234924.GB3898@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([212.34.189.10]:10122 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S261988AbUEVXt0 (ORCPT ); Sat, 22 May 2004 19:49:26 -0400 Received: from verein.lst.de (localhost [127.0.0.1]) by mail.lst.de (8.12.3/8.12.3/Debian-6.6) with ESMTP id i4MNnOQc003951 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Sun, 23 May 2004 01:49:25 +0200 Received: (from hch@localhost) by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id i4MNnOas003949 for linux-fsdevel@vger.kernel.org; Sun, 23 May 2004 01:49:24 +0200 To: linux-fsdevel@vger.kernel.org Content-Disposition: inline List-Id: linux-fsdevel.vger.kernel.org currently isofs marks filenames witout periods as executable which is rather odd. The Debian kernel package has an old patch to sanitize this behaviour and I wonder whether we should get it into mainline. * Removed period check for executables in fs/isofs/inode.c --- kernel-source-2.6.6/fs/isofs/inode.c 2004-05-10 19:48:03.000000000 +1000 +++ kernel-source-2.6.6-1/fs/isofs/inode.c 2004-05-10 22:21:47.000000000 +1000 @@ -1250,14 +1250,6 @@ inode->i_mode = sbi->s_mode; inode->i_nlink = 1; inode->i_mode |= S_IFREG; - /* If there are no periods in the name, - * then set the execute permission bit - */ - for(i=0; i< de->name_len[0]; i++) - if(de->name[i]=='.' || de->name[i]==';') - break; - if(i == de->name_len[0] || de->name[i] == ';') - inode->i_mode |= S_IXUGO; /* execute permission */ } inode->i_uid = sbi->s_uid; inode->i_gid = sbi->s_gid;