From: Andrew Morton <akpm@osdl.org>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: sfrench@us.ibm.com, linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: Fw: Re: Process hangs copying large file to cifs filesystem
Date: Fri, 25 Jun 2004 11:32:14 -0700 [thread overview]
Message-ID: <20040625113214.3324d830.akpm@osdl.org> (raw)
In-Reply-To: <20040625145234.GN12308@parcelfarce.linux.theplanet.co.uk>
viro@parcelfarce.linux.theplanet.co.uk wrote:
>
> On Fri, Jun 25, 2004 at 01:29:31AM -0700, Andrew Morton wrote:
> >
> > This person's CIFS hang is happening because the hlist_unhashed() test in
> > __mark_inode_dirty() is returning true, so the inode never gets itself onto
> > sb->s_dirty. The writeback paths have no way to write out the pagecache.
> >
> > a) Why are CIFS inodes not hashed?
>
> Presumably because it never does hash lookups. I wonder where it gets
> inumbers from, though - keeping them unique would at least require being
> able to see what's already in-core.
hm. Well cifs inodes seem to have unique i_ino's somehow.
> > b) Why does __mark_inode_dirty() skip unhashed inodes anyway?
>
> Ask Linus. I've always treated that as a behaviour filesystems might be
> using, and IIRC in some cases that was deliberately used. I have my
> suspicions about the origin of that animal, but that was before my time
> (during 2.1.50ish rewrite of inode.c) and inode.c is one place I try
> to touch as rarely as possible...
Linus, why does __mark_inode_dirty() skip unhashed inodes?
next prev parent reply other threads:[~2004-06-25 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-25 8:29 Fw: Re: Process hangs copying large file to cifs filesystem Andrew Morton
2004-06-25 14:52 ` viro
2004-06-25 18:32 ` Andrew Morton [this message]
2004-06-25 18:48 ` Linus Torvalds
2004-06-25 19:39 ` Andrew Morton
[not found] ` <OF980F9E62.86CA6214-ON87256EBE.007E2269-86256EBE.007E1390@us.ibm.com>
2004-06-25 23:52 ` Andrew Morton
2004-06-25 20:03 ` Linus Torvalds
2004-06-25 20:21 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040625113214.3324d830.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).