linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: viro@parcelfarce.linux.theplanet.co.uk, sfrench@us.ibm.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: Fw: Re: Process hangs copying large file to cifs filesystem
Date: Fri, 25 Jun 2004 12:39:34 -0700	[thread overview]
Message-ID: <20040625123934.03573f0f.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0406251135490.1844@ppc970.osdl.org>

Linus Torvalds <torvalds@osdl.org> wrote:
>
> 
> 
> On Fri, 25 Jun 2004, Andrew Morton wrote:
> > 
> > Linus, why does __mark_inode_dirty() skip unhashed inodes?
> 
> Hah. I wouldn't remember for the life of me. There could be multiple 
> reasons, all of which I've forgotten:
> 
>  - ramfs deadlocks on "sync()", since it can't write out inodes

hm.  ramfs oopses on null ->writepage without the check.  I'll fix that up.

>  - stale and bad inodes get unhashed, and end up being unwritable.

Maybe we should check inode sanity in the writing path, rather than the
dirtying path.  We already check is_bad_inode() in write_inode().

>  - totally stale reason that doesn't exist any more.
> 
> I suspect #3 migth well be true, but it's a scary change to try.

It is indeed scary, yes.  I think the path of least resistance here is for
cifs to start hashing dem inodes.


  reply	other threads:[~2004-06-25 19:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-25  8:29 Fw: Re: Process hangs copying large file to cifs filesystem Andrew Morton
2004-06-25 14:52 ` viro
2004-06-25 18:32   ` Andrew Morton
2004-06-25 18:48     ` Linus Torvalds
2004-06-25 19:39       ` Andrew Morton [this message]
     [not found]         ` <OF980F9E62.86CA6214-ON87256EBE.007E2269-86256EBE.007E1390@us.ibm.com>
2004-06-25 23:52           ` Andrew Morton
2004-06-25 20:03       ` Linus Torvalds
2004-06-25 20:21         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040625123934.03573f0f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sfrench@us.ibm.com \
    --cc=torvalds@osdl.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).