* [patch 1/6] ext2_setattr retval fix
@ 2004-06-26 22:00 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2004-06-26 22:00 UTC (permalink / raw)
To: mason; +Cc: shaggy, sfrench, vandrove, zippel, agruen, linux-fsdevel, akpm
ext2_setattr() drops the inode_setattr() return value on the floor. This is
very bad - I/O errors during truncate are lost.
The patch changes ext2_setattr() so that we no longer call ext2_acl_chmod() if
inode_setattr(), which is what ext3 does.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/ext2/inode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/ext2/inode.c~setattr-retval-fixes fs/ext2/inode.c
--- 25/fs/ext2/inode.c~setattr-retval-fixes 2004-06-26 14:35:58.479309024 -0700
+++ 25-akpm/fs/ext2/inode.c 2004-06-26 14:35:58.483308416 -0700
@@ -1276,8 +1276,8 @@ int ext2_setattr(struct dentry *dentry,
if (error)
return error;
}
- inode_setattr(inode, iattr);
- if (iattr->ia_valid & ATTR_MODE)
+ error = inode_setattr(inode, iattr);
+ if (!error && (iattr->ia_valid & ATTR_MODE))
error = ext2_acl_chmod(inode);
return error;
}
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-06-26 22:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-26 22:00 [patch 1/6] ext2_setattr retval fix akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).