From: akpm@osdl.org
To: mason@suse.com
Cc: shaggy@austin.ibm.com, sfrench@us.ibm.com, vandrove@vc.cvut.cz,
zippel@linux-m68k.org, agruen@suse.de,
linux-fsdevel@vger.kernel.org, akpm@osdl.org
Subject: [patch 3/6] jfs_setattr() fix
Date: Sat, 26 Jun 2004 15:00:33 -0700 [thread overview]
Message-ID: <200406262201.i5QM1SZ06666@mail.osdl.org> (raw)
jfs is dropping inode_setattr()'s return value.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/jfs/acl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/jfs/acl.c~jfs_setattr-fix fs/jfs/acl.c
--- 25/fs/jfs/acl.c~jfs_setattr-fix 2004-06-26 14:41:27.039360304 -0700
+++ 25-akpm/fs/jfs/acl.c 2004-06-26 14:41:39.249504080 -0700
@@ -281,9 +281,9 @@ int jfs_setattr(struct dentry *dentry, s
if (rc)
return rc;
- inode_setattr(inode, iattr);
+ rc = inode_setattr(inode, iattr);
- if (iattr->ia_valid & ATTR_MODE)
+ if (!rc && (iattr->ia_valid & ATTR_MODE))
rc = jfs_acl_chmod(inode);
return rc;
_
reply other threads:[~2004-06-26 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406262201.i5QM1SZ06666@mail.osdl.org \
--to=akpm@osdl.org \
--cc=agruen@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mason@suse.com \
--cc=sfrench@us.ibm.com \
--cc=shaggy@austin.ibm.com \
--cc=vandrove@vc.cvut.cz \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).