linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 3/6] jfs_setattr() fix
@ 2004-06-26 22:00 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2004-06-26 22:00 UTC (permalink / raw)
  To: mason; +Cc: shaggy, sfrench, vandrove, zippel, agruen, linux-fsdevel, akpm



jfs is dropping inode_setattr()'s return value.

Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/fs/jfs/acl.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN fs/jfs/acl.c~jfs_setattr-fix fs/jfs/acl.c
--- 25/fs/jfs/acl.c~jfs_setattr-fix	2004-06-26 14:41:27.039360304 -0700
+++ 25-akpm/fs/jfs/acl.c	2004-06-26 14:41:39.249504080 -0700
@@ -281,9 +281,9 @@ int jfs_setattr(struct dentry *dentry, s
 	if (rc)
 		return rc;
 
-	inode_setattr(inode, iattr);
+	rc = inode_setattr(inode, iattr);
 
-	if (iattr->ia_valid & ATTR_MODE)
+	if (!rc && (iattr->ia_valid & ATTR_MODE))
 		rc = jfs_acl_chmod(inode);
 
 	return rc;
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-06-26 22:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-26 22:00 [patch 3/6] jfs_setattr() fix akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).